Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix up #915: bump the PyO3's abi3 feature to abi3-py310 #926

Merged

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Jan 18, 2025

内容

これをやらないとwhl名が"…-cp38-abi3-…"のままになり、誤解を生じさせることが予想できるため。

See-also: https://pyo3.rs/v0.23.4/building-and-distribution#minimum-python-version-for-abi3

関連 Issue

その他

@qryxip qryxip requested a review from Hiroshiba January 18, 2025 05:59
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

テスト落ちてるかもです!

@qryxip
Copy link
Member Author

qryxip commented Jan 18, 2025

ea9c89a (#926): なんか今までGHA環境に備え付けのPython 3.9を使ってたっぽいので、Python 3.10を使うようにしました。

@qryxip qryxip merged commit df82ffe into VOICEVOX:main Jan 18, 2025
29 checks passed
@qryxip qryxip deleted the fix-bump-pyo3s-abi3-feature-to-abi3-py310 branch January 18, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants